Room list: add default sections#32785
Merged
florianduros merged 22 commits intodevelopfrom Mar 31, 2026
Merged
Conversation
florianduros
force-pushed
the
florianduros/default-sections
branch
from
a4c3759 to
8cf41df
Compare
florianduros
force-pushed
the
florianduros/section-shared-component
branch
2 times, most recently
from
a9078e2 to
e4856f6
Compare
Base automatically changed from
florianduros/section-shared-component
to
develop
March 16, 2026 16:56
florianduros
force-pushed
the
florianduros/default-sections
branch
2 times, most recently
from
c880f80 to
57b47eb
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
florianduros
force-pushed
the
florianduros/default-sections
branch
2 times, most recently
from
47a8dfb to
c853af8
Compare
florianduros
force-pushed
the
florianduros/default-sections
branch
from
c853af8 to
d57acac
Compare
florianduros
force-pushed
the
florianduros/default-sections
branch
from
d57acac to
712fbbb
Compare
florianduros
force-pushed
the
florianduros/default-sections
branch
from
712fbbb to
2f13fad
Compare
florianduros
force-pushed
the
florianduros/default-sections
branch
from
2f13fad to
049c49f
Compare
florianduros
force-pushed
the
florianduros/default-sections
branch
from
0504366 to
726481e
Compare
| /** | ||
| * Contains all the rooms in the active space | ||
| */ | ||
| private rooomSkipList?: RoomSkipList; |
Member
There was a problem hiding this comment.
Suggested change
| private rooomSkipList?: RoomSkipList; | |
| private roomSkipList?: RoomSkipList; |
typo
| /** | ||
| * Maps section tags to their corresponding skip lists. | ||
| */ | ||
| private roomSkipListByTag: Map<string, RoomSkipList> = new Map(); |
Member
There was a problem hiding this comment.
I wonder if we could have just used the existing single skip-list. If you add the the section filters to the skip-list, then could you not just call this.roomSkipList.getRoomsInActiveSpace(filterKeyForSection)?
Member
Author
There was a problem hiding this comment.
Hmm that's a valid suggestion, i'll try to do it
Half-Shot
requested changes
Mar 30, 2026
Member
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
Looks sensible overall. Caught a few things but nothing serious.
apps/web/src/stores/room-list-v3/skip-list/filters/ExcludeTagsFilter.ts
Outdated
Show resolved
Hide resolved
apps/web/src/stores/room-list-v3/skip-list/filters/TagFilter.ts
Outdated
Show resolved
Hide resolved
...ux/__baselines__/room-list/RoomListView/RoomListView.stories.tsx/large-section-list-auto.png
Show resolved
Hide resolved
packages/shared-components/src/room-list/VirtualizedRoomListView/VirtualizedRoomListView.tsx
Show resolved
Hide resolved
packages/shared-components/src/room-list/VirtualizedRoomListView/VirtualizedRoomListView.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32452
This PR adds the support of the favourite and low priority default sections under the
feature_room_list_sectionslabs flag.The PR main content is the sections support in the room list store and in the room list view model. The sections support in the views were added in #32735 and #32566.
Screen.Recording.2026-03-25.at.16.29.22.mov