-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove automaticErrorReporting labs feature #32781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3
−21
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1a9f980
Disable changing automaticErrorReporting unless sentry is configured.
Half-Shot 949dcad
Ensure we reload on change
Half-Shot 437b934
Remove automaticErrorReporting labs flag
Half-Shot eaed81a
remove stray import
Half-Shot 1beb573
I thought I had killed you
Half-Shot 3c8a8a2
poke ci
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
apps/web/src/settings/controllers/CompatibilityCheckController.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| Copyright 2026 Element Creations Ltd. | ||
|
|
||
| SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial | ||
| Please see LICENSE files in the repository root for full details. | ||
| */ | ||
|
|
||
| import SettingController from "./SettingController"; | ||
| import { type SettingLevel } from "../SettingLevel"; | ||
| import PlatformPeg from "../../PlatformPeg"; | ||
|
|
||
| /** | ||
| * Enforces that a boolean setting cannot be changed if a function returns false. | ||
| */ | ||
| export default class CompatibilityCheckController extends SettingController { | ||
| /** | ||
| * @param compatibleCheck A function that checks if the setting is incompatible. May return a reason string. | ||
| * @param forcedValue The forced value if the setting is incompatible. | ||
| */ | ||
| public constructor( | ||
| private readonly compatibleCheck: () => boolean | string, | ||
| private readonly forcedValue = false, | ||
| private readonly reloadOnChange = false, | ||
| ) { | ||
| super(); | ||
| } | ||
|
|
||
| public getValueOverride( | ||
| level: SettingLevel, | ||
| roomId: string, | ||
| calculatedValue: any, | ||
| calculatedAtLevel: SettingLevel | null, | ||
| ): any { | ||
| if (!this.compatibleSetting) { | ||
| return this.forcedValue; | ||
| } | ||
| return null; // no override | ||
| } | ||
|
|
||
| public onChange(): void { | ||
| if (this.reloadOnChange) { | ||
| PlatformPeg.get()?.reload(); | ||
| } | ||
| } | ||
|
|
||
| public get settingDisabled(): boolean | string { | ||
| return this.compatibleSetting; | ||
| } | ||
|
|
||
| public get compatibleSetting(): boolean | string { | ||
| return this.compatibleCheck(); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.