Skip to content

Fix nx configuration to actually run type linter #32776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richvdh merged 3 commits into from
Mar 13, 2026
+6 −3
Merged

Fix nx configuration to actually run type linter #32776

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2261b8
do not indirect tsc commands via tsc
richvdh Mar 12, 2026
c831cda
Merge branch 'develop' into rav/no-tsc-via-pnpm
richvdh Mar 12, 2026
94cd37e
Reinstate indirection via pnpm
richvdh Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/web/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,12 @@
"executor": "nx:run-commands",
"options": {
"commands": [
"pnpm tsc --noEmit --project ./tsconfig.module_system.json",
"pnpm tsc --noEmit",
"pnpm tsc --noEmit -p playwright"
// We indirect via `pnpm exec` to stop knip interpreting the
// commandline and declaring `playwright` and `./tsconfig.module_system.json`
// as unlisted dependencies.
Comment on lines +37 to +39
Copy link
Copy Markdown
Member

@florianduros florianduros Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose nx accepts comments in json

Copy link
Copy Markdown
Member Author

@richvdh richvdh Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankfully it seems to, yes

"pnpm exec tsc --noEmit --project ./tsconfig.module_system.json",
"pnpm exec tsc --noEmit",
"pnpm exec tsc --noEmit --project playwright"
],
"parallel": false,
"cwd": "apps/web"
Expand Down
Loading