Skip to content

Room list: add sections to shared components #32735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianduros merged 16 commits into from
Mar 16, 2026

chore: fix typo in example doc

10cb463
Select commit
Loading
Failed to load commit list.
Merged

Room list: add sections to shared components #32735

chore: fix typo in example doc
10cb463
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 16, 2026 in 1m 6s

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 113 in packages/shared-components/src/room-list/RoomListSectionHeaderView/RoomListSectionHeaderView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <td> instead of the "gridcell" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzYxwi-ztpHVdMFaeFz&open=AZzYxwi-ztpHVdMFaeFz&pullRequest=32735

Check warning on line 333 in packages/shared-components/src/room-list/VirtualizedRoomListView/VirtualizedRoomListView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzYxwivztpHVdMFaeFw&open=AZzYxwivztpHVdMFaeFw&pullRequest=32735

Check warning on line 49 in packages/shared-components/src/room-list/RoomListItemAccessibilityWrapper/RoomListItemAccessibilityWrapper.stories.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <select size=...>, <select multiple=...>, or <datalist> instead of the "listbox" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzYxwh3ztpHVdMFaeFr&open=AZzYxwh3ztpHVdMFaeFr&pullRequest=32735

Check warning on line 81 in packages/shared-components/src/room-list/RoomListItemView/RoomListItemView.stories.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <select size=...>, <select multiple=...>, or <datalist> instead of the "listbox" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzYxwhlztpHVdMFaeFp&open=AZzYxwhlztpHVdMFaeFp&pullRequest=32735

Check warning on line 196 in packages/shared-components/src/room-list/VirtualizedRoomListView/VirtualizedRoomListView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `.indexOf()` instead of `.findIndex()` when looking for the index of an item. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzYxwivztpHVdMFaeFv&open=AZzYxwivztpHVdMFaeFv&pullRequest=32735
View more details on SonarQubeCloud