-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Port over linkifyJS to shared-components. #32731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
a253f84
Port over linkifyJS to shared-components.
Half-Shot a8efa1b
Drop rubbish
Half-Shot db34d93
update lock
Half-Shot 6a57306
quickfix test
Half-Shot 9a88517
drop group id
Half-Shot 291aa48
Modernize tests
Half-Shot bc362bd
Remove stories that aren't in use.
Half-Shot 378abba
Complete working version
Half-Shot 7198404
Add copyright
Half-Shot 9cc4a6c
tidy up
Half-Shot 0ef3801
update lock
Half-Shot e8bd436
Update snaps
Half-Shot 6488fdb
update snap
Half-Shot c0f3e37
undo change
Half-Shot c9cf144
remove unused
Half-Shot c52d59d
More test updates
Half-Shot ba405f5
fix typo
Half-Shot 878baef
fix margin on preview
Half-Shot 861730c
move margin block
Half-Shot 79ea08a
snapupdate
Half-Shot f019cf3
prettier
Half-Shot d7a42d4
cleanup a test mistake
Half-Shot 57e2d80
Fixup sonar issues
Half-Shot 609da31
Don't expose linkifyjs to applications, just provide helper functions.
Half-Shot db98064
Add story for documentation.
Half-Shot 6068490
remove $
Half-Shot cd36c02
Use a const
Half-Shot 9549c7c
typo
Half-Shot 4263b28
cleanup var name
Half-Shot 4ca3c93
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 548b376
remove console line
Half-Shot a83e18a
Changes checkpoint
Half-Shot 1707c33
Convert to context
Half-Shot e2aa463
Revert unrelated change.
Half-Shot 51b8c6f
more cleanup
Half-Shot d9dd9cc
Add a test to cover ignoring incoming data elements
Half-Shot bceed65
Make tests happy
Half-Shot 813b295
Update tests for LinkedText
Half-Shot c55a595
Underlines!
Half-Shot d1211f8
fix lock
Half-Shot 9bd6339
remove unused linkify packages
Half-Shot b048b00
import move
Half-Shot 34f0c35
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 73404ad
Remove mod to remove underline
Half-Shot d92f671
undo
Half-Shot e50b126
fix snap
Half-Shot 6dc68b7
another snapshot fix
Half-Shot eba6cf0
Tidy up based on review.
Half-Shot d606872
fix story
Half-Shot a9afb3d
Pass in args
Half-Shot 5913893
Merge remote-tracking branch 'origin/develop' into hs/partial-linkify…
Half-Shot 4e6ef15
Merge branch 'develop' into hs/partial-linkify-move
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this allow
data-linkifieduser-controlled from Matrix Events against the Matrix spec? iirc where we do something similar withstylewe have to manually sanitise it to ensure it only allows values the app injects rather than those from user-controller contentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've written a test to check for this d9dd9cc.