Skip to content

Room list: avoid excessive re-renders on room list store update or filter change #32663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianduros merged 7 commits into from
Mar 2, 2026
Merged

Room list: avoid excessive re-renders on room list store update or filter change #32663

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
24dc90c
perf(room list): clear room list item vm only when changing space
florianduros Feb 27, 2026
9d79450
perf(room list): avoid to re-render filters at every room list update
florianduros Feb 27, 2026
135f572
chore: add `keepIfSame` to do diff on vm objects
florianduros Feb 27, 2026
b5c879a
perf(room list): avoid to create new filter ids and keys when the roo…
florianduros Feb 27, 2026
728e3da
test(room list): remove no longer relevant test
florianduros Feb 27, 2026
36646e4
test(room list): add new test to ensure that room list item vms are p…
florianduros Feb 27, 2026
52e09a3
Merge branch 'develop' into florianduros/room-list-performance
florianduros Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apps/web/src/viewmodels/room-list/RoomListViewViewModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,6 @@ export class RoomListViewViewModel
// Update roomsMap immediately before clearing VMs
this.updateRoomsMap(this.roomsResult);

// Clear view models since room list changed
this.clearViewModels();
Copy link
Copy Markdown
Member

@langleyd langleyd Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the flip side of this is that some of these VMs will had around int he map until removed. But as you said when the visible rooms change they will be cleaned up.


this.updateRoomListData();
};

Expand Down Expand Up @@ -291,11 +288,13 @@ export class RoomListViewViewModel

const newSpaceId = this.roomsResult.spaceId;

// Clear view models since room list structure changed
this.clearViewModels();

// Detect space change
if (oldSpaceId !== newSpaceId) {
// Clear view models when the space changes
// We only want to do this on space changes, not on regular list updates, to preserve view models when possible
// The view models are disposed when scrolling out of view (handled by updateVisibleRooms)
this.clearViewModels();

// Space changed - get the last selected room for the new space to prevent flicker
const lastSelectedRoom = SpaceStore.instance.getLastSelectedRoomIdForSpace(newSpaceId);

Expand Down
8 changes: 4 additions & 4 deletions packages/shared-components/src/room-list/RoomListPrimaryFilters/RoomListPrimaryFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Please see LICENSE files in the repository root for full details.
*/

import React, { type JSX, useId, useState } from "react";
import React, { type JSX, memo, useId, useState } from "react";
import { ChatFilter, IconButton } from "@vector-im/compound-web";
import ChevronDownIcon from "@vector-im/compound-design-tokens/assets/web/icons/chevron-down";

Expand Down Expand Up @@ -53,11 +53,11 @@ export interface RoomListPrimaryFiltersProps {
* The primary filters component for the room list.
* Displays a collapsible list of filters with expand/collapse functionality.
*/
export const RoomListPrimaryFilters: React.FC<RoomListPrimaryFiltersProps> = ({
export const RoomListPrimaryFilters = memo(function RoomListPrimaryFilters({
filterIds,
activeFilterId,
onToggleFilter,
}): JSX.Element | null => {
}: RoomListPrimaryFiltersProps): JSX.Element | null {
const id = useId();
const [isExpanded, setIsExpanded] = useState(false);

Expand Down Expand Up @@ -113,4 +113,4 @@ export const RoomListPrimaryFilters: React.FC<RoomListPrimaryFiltersProps> = ({
</Flex>
</Flex>
);
};
});
Loading