Prevent logging lots of "Browser unsupported" lines#32647
Merged
Conversation
Half-Shot
changed the title
t3chguy
reviewed
Feb 26, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
The extra logging is intentional, so that it gets glued to the end of a rageshake log, this seems like it'd lose that
Member
Author
It's creating a shit ton of dupes. Can we instead put it in the rageshake metadata if it's essential? |
Member
|
Sure |
t3chguy
reviewed
Feb 26, 2026
t3chguy
reviewed
Feb 26, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Seems to make tests very unhappy
t3chguy
approved these changes
Feb 27, 2026
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
You could probably just wrap the function in memoize-one which we use elsewhere, though won't block on it. Looks sane
t3chguy
reviewed
Feb 27, 2026
t3chguy
approved these changes
Feb 27, 2026
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Mar 10, 2026
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [vectorim/element-web](https://github.com/element-hq/element-web) | patch | `v1.12.11` → `v1.12.12` | --- ### Release Notes <details> <summary>element-hq/element-web (vectorim/element-web)</summary> ### [`v1.12.12`](https://github.com/element-hq/element-web/releases/tag/v1.12.12) [Compare Source](element-hq/element-web@v1.12.11...v1.12.12) #### ✨ Features - Add stable support for MSC4380 invite blocking ([#​31966](element-hq/element-web#31966)). Contributed by [@​richvdh](https://github.com/richvdh). - Hide the names of banned users behind a spoiler tag ([#​32424](element-hq/element-web#32424)). Contributed by [@​andybalaam](https://github.com/andybalaam). - Room list: remove bold effect on selected room ([#​32593](element-hq/element-web#32593)). Contributed by [@​florianduros](https://github.com/florianduros). - Use Compound buttons in auth screens ([#​32562](element-hq/element-web#32562)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Track room list sorting algorithm changes ([#​32556](element-hq/element-web#32556)). Contributed by [@​MidhunSureshR](https://github.com/MidhunSureshR). - Update `sso_redirect_options` to work for Native OIDC ([#​32537](element-hq/element-web#32537)). Contributed by [@​t3chguy](https://github.com/t3chguy). #### 🐛 Bug Fixes - Room list: avoid excessive re-renders on room list store update or filter change ([#​32663](element-hq/element-web#32663)). Contributed by [@​florianduros](https://github.com/florianduros). - Room list: listen to call event to check number of participants ([#​32677](element-hq/element-web#32677)). Contributed by [@​florianduros](https://github.com/florianduros). - Fix invite-specific join errors not being shown ([#​32621](element-hq/element-web#32621)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - Prevent logging lots of "Browser unsupported" lines ([#​32647](element-hq/element-web#32647)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - Update critical gradient for room status bar ([#​32575](element-hq/element-web#32575)). Contributed by [@​Half-Shot](https://github.com/Half-Shot). - Room list: avoid header overflowing when too long ([#​32645](element-hq/element-web#32645)). Contributed by [@​florianduros](https://github.com/florianduros). - Room list: center focus outline of room list item ([#​32637](element-hq/element-web#32637)). Contributed by [@​florianduros](https://github.com/florianduros). - Fix misaligned cross in complete security dialog ([#​32614](element-hq/element-web#32614)). Contributed by [@​dbkr](https://github.com/dbkr). - Room list: fix keyboard navigation ([#​32585](element-hq/element-web#32585)). Contributed by [@​florianduros](https://github.com/florianduros). - Don't show empty privacy section ([#​32582](element-hq/element-web#32582)). Contributed by [@​dbkr](https://github.com/dbkr). - Disable room list image dragging ([#​32590](element-hq/element-web#32590)). Contributed by [@​florianduros](https://github.com/florianduros). - Update UserMenu theme toggle to use IconButton ([#​32591](element-hq/element-web#32591)). Contributed by [@​t3chguy](https://github.com/t3chguy). - Room list: make room list item scales with large font size ([#​32523](element-hq/element-web#32523)). Contributed by [@​florianduros](https://github.com/florianduros). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41OS4yIiwidXBkYXRlZEluVmVyIjoiNDMuNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIiwiaW1hZ2UiXX0=--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/4596 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents us logging absolutely tons of lines in rageshakes about unsupported browsers. We only need the one message.
Checklist
public/exportedsymbols have accurate TSDoc documentation.