Do non-layered builds when running on master (second version)#32624
Merged
Do non-layered builds when running on master (second version)#32624
Conversation
Hopefully this will fix the release as it looks like we've introduced backwards incompat changes in the js-sdk between the RC and the release, which have now broken as we were incorrectly using the develop js-sdk for release builds. Replaces #32623
t3chguy
reviewed
Feb 25, 2026
scripts/layered.sh
Outdated
| fi | ||
|
|
||
| # Also set up matrix-analytics-events for branch with matching name | ||
| if [ "$analytics_events_dep" = "github:matrix-org/matrix-analytics-events#develop" ]; then |
Member
There was a problem hiding this comment.
I don't think this ever happens. TBH I think we should just nuke this branch match.
t3chguy
reviewed
Feb 25, 2026
| js_sdk_dep=`jq -r '.dependencies["matrix-js-sdk"]' < package.json` | ||
| analytics_events_dep=`jq -r '.dependencies["@matrix-org/analytics-events"]' < package.json` | ||
|
|
||
| # Set up the js-sdk first (unless package.json pins a specific version) |
Member
There was a problem hiding this comment.
Suggested change
| # Set up the js-sdk first (unless package.json pins a specific version) | |
| # Set up the js-sdk (unless package.json pins a specific version) |
t3chguy
reviewed
Feb 25, 2026
scripts/layered.sh
Outdated
| if [ -d matrix-analytics-events ]; then | ||
| pushd matrix-analytics-events | ||
| js_sdk_dep=`jq -r '.dependencies["matrix-js-sdk"]' < package.json` | ||
| analytics_events_dep=`jq -r '.dependencies["@matrix-org/analytics-events"]' < package.json` |
t3chguy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this will fix the release as it looks like we've introduced backwards incompat changes in the js-sdk between the RC and the release, which have now broken as we were incorrectly using the develop js-sdk for release builds.
Replaces #32623
Checklist
public/exportedsymbols have accurate TSDoc documentation.