Skip to content

Room list: add a grouped virtualized list to shared components #32566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianduros merged 12 commits into from
Mar 13, 2026

Merge branch 'develop' into florianduros/grouped-virtuallist

fd68dc9
Select commit
Loading
Failed to load commit list.
Merged

Room list: add a grouped virtualized list to shared components #32566

Merge branch 'develop' into florianduros/grouped-virtuallist
fd68dc9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 13, 2026 in 1m 3s

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 373 in packages/shared-components/src/utils/VirtualizedList/virtualized-list.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyPw43ii9jPwfYhsq25&open=AZyPw43ii9jPwfYhsq25&pullRequest=32566

Check warning on line 37 in packages/shared-components/src/utils/VirtualizedList/FlatVirtualizedList/FlatVirtualizedList.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyPw47qi9jPwfYhsq26&open=AZyPw47qi9jPwfYhsq26&pullRequest=32566

Check warning on line 95 in packages/shared-components/src/utils/VirtualizedList/story-mock.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use <td> instead of the "gridcell" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZzSYYdZC1LEfgiI9VK0&open=AZzSYYdZC1LEfgiI9VK0&pullRequest=32566

Check warning on line 119 in packages/shared-components/src/utils/VirtualizedList/GroupedVirtualizedList/GroupedVirtualizedList.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyQx-hNZyB6hK62zVNT&open=AZyQx-hNZyB6hK62zVNT&pullRequest=32566

Check failure on line 257 in packages/shared-components/src/utils/VirtualizedList/virtualized-list.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZyPw43ii9jPwfYhsq24&open=AZyPw43ii9jPwfYhsq24&pullRequest=32566
View more details on SonarQubeCloud