Stabilise sliding sync playwright test #28879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no guarantee that the unsubscription & subscription occur in the same request given the add/remove APIs are async Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…to t3chguy/stabilise-sliding-sync-subs-test # Conflicts: # playwright/element-web-test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no guarantee that the unsubscription & subscription occur in the same request given the add/remove APIs are async. The setting of the sliding sync proxy was also racing with the other init script, causing it to be flaky.
Fixes #28851
Fixes #28866
Fixes #28873
Fixes #28865
Fixes #28875