Skip to content

Enable element call by default on sample config#28491

Closed
yajo wants to merge 2 commits intoelement-hq:developfrom
yajo:element-call-enabled-sample-config
Closed

Enable element call by default on sample config#28491
yajo wants to merge 2 commits intoelement-hq:developfrom
yajo:element-call-enabled-sample-config

Conversation

@yajo
Copy link
Copy Markdown

@yajo yajo commented Nov 19, 2024

Following the same logic from #28314, this patch enables Element Call by default for other configs.

Downstream distributions that use the sample config should start using Element Call also!

Example: https://discourse.nixos.org/t/element-call-not-enabled-in-element-desktop/56077/3?u=yajo

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Following the same logic from element-hq#28314, this patch enables Element Call by default for other configs.

Downstream distributions that use the sample config should start using Element Call also!

Example: https://discourse.nixos.org/t/element-call-not-enabled-in-element-desktop/56077/3?u=yajo
@yajo yajo requested a review from a team as a code owner November 19, 2024 16:37
@yajo yajo requested review from robintown and t3chguy November 19, 2024 16:37
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Nov 19, 2024
@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Jan 27, 2025

I don't think the sample config should rely on labs flags. The EC rollout to app.element.io and similar was a choice by the Product team. Other deployments can opt-in or await EC leaving labs.

@t3chguy t3chguy closed this Jan 27, 2025
@yajo yajo deleted the element-call-enabled-sample-config branch January 29, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants