Skip to content

Update labs.md for knock rooms#25923

Merged
germain-gg merged 1 commit intoelement-hq:developfrom
nordeck:charlynguyen/update-labs-md-for-knock-rooms
Aug 4, 2023
Merged

Update labs.md for knock rooms#25923
germain-gg merged 1 commit intoelement-hq:developfrom
nordeck:charlynguyen/update-labs-md-for-knock-rooms

Conversation

@charlynguyen
Copy link
Copy Markdown
Contributor

@charlynguyen charlynguyen commented Aug 4, 2023

We @nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in matrix-org/matrix-react-sdk#11182).

This pull request updates the labs.md for knock rooms.

Relates to

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement labels Aug 4, 2023
@charlynguyen charlynguyen marked this pull request as ready for review August 4, 2023 09:39
@charlynguyen charlynguyen requested a review from a team as a code owner August 4, 2023 09:39
@germain-gg germain-gg merged commit 15836ac into element-hq:develop Aug 4, 2023
@charlynguyen charlynguyen deleted the charlynguyen/update-labs-md-for-knock-rooms branch August 4, 2023 14:56
@catfromplan9
Copy link
Copy Markdown

When feature_ask_to_join is enabled in labs, I still don't see the "People" tab in room settings. How to fix?

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Aug 17, 2023

@catfromplan9 did you set the rooms join rule to knock/ask to join first..?

@catfromplan9
Copy link
Copy Markdown

@catfromplan9 did you set the rooms join rule to knock/ask to join first..?

Yes, and i requested to join on my alt. Im not seeing the request but i can use my instance to request to join rooms with that setting

@catfromplan9
Copy link
Copy Markdown

@catfromplan9 did you set the rooms join rule to knock/ask to join first..?

Yes, and i requested to join on my alt. Im not seeing the request but i can use my instance to request to join rooms with that setting

I deployed latest element from develop branch today. I have the ask to join function itself, just not the tab for accepting invites. develop.element.io works though

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Aug 18, 2023

@catfromplan9 if it works on develop.element.io but not on your custom develop branch deployment then the issue sounds on your end. Keep in mind the feature only merged 2 days ago so definitely won't be in any release tags. https://github.com/vector-im/element-web/blob/develop/.github/workflows/build_develop.yml for how develop is built & deployed.

@catfromplan9
Copy link
Copy Markdown

@catfromplan9 if it works on develop.element.io but not on your custom develop branch deployment then the issue sounds on your end. Keep in mind the feature only merged 2 days ago so definitely won't be in any release tags. https://github.com/vector-im/element-web/blob/develop/.github/workflows/build_develop.yml for how develop is built & deployed.

I ran this

git clone https://github.com/vector-im/element-web
cd element-web
yarn
yarn install
yarn dist

Then i untarred it in my webroot, and set the following settings (atleast the ones relevant to this issue) in my config.json

"showLabsSettings": true,
    "features": {
        "feature_many_integration_managers": "labs",
        "feature_pinning": "enable",
        "feature_html_topic": "labs",
        "feature_new_room_decoration_ui": "labs",
        "feature_custom_status": "enable",
        "feature_custom_tags": "labs",
        "feature_state_counters": "labs",
        "feature_custom_themes": "enable",
        "feature_bridge_state": "enable",
        "feature_mjolnir": "enable",
        "feature_ask_to_join": "enable",
        "feature_presence_in_room_list": "labs",
        "feature_roomlist_preview_reactions_all": "labs",
        "feature_roomlist_preview_reactions_dms": "labs",
        "feature_dm_verification": "labs",
        "feature_latex_maths": "labs",
        "feature_dehydration": "labs",
        "feature_report_to_moderators": "labs",
        "feature_hidden_read_receipts": "labs",
        "feature_polls": "enable",
        "feature_location_share_pin_drop": "labs",
        "feature_location_share_live": "labs",
        "feature_breadcrumbs_v2": "labs",
        "feature_spotlight": "labs",
        "feature_jump_to_date": "enable",
        "feature_voice_rooms": "enable",
        "feature_extensible_events": "labs"
    },

@t3chguy
Copy link
Copy Markdown
Member

t3chguy commented Aug 18, 2023

Closed issues aren't support tickets @catfromplan9 - seek support in #element-web:matrix.org. If you have an actual bug to report then open a distinct issue.

@element-hq element-hq locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Enhancement Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants