Bump @matrix-org/react-sdk-module-api to 0.0.4#24642
Merged
andybalaam merged 7 commits intodevelopfrom Mar 2, 2023
Merged
Conversation
Contributor
|
@andybalaam it seems that the pipeline should be fine if restarted, so maybe could try to merge |
t3chguy
requested changes
Mar 1, 2023
Member
t3chguy
left a comment
There was a problem hiding this comment.
Seems like no bumping actually happened given no yarn.lock change
Member
Author
t3chguy
requested changes
Mar 1, 2023
yarn.lock
Outdated
| "matrix-react-sdk@github:matrix-org/matrix-react-sdk#develop": | ||
| version "3.67.0" | ||
| resolved "https://codeload.github.com/matrix-org/matrix-react-sdk/tar.gz/da2fcdd3462bfcc3ee0033f2d5303942521e1df5" | ||
| resolved "https://codeload.github.com/matrix-org/matrix-react-sdk/tar.gz/4f1e5a71dec65258f5295f7d60d2e733391d304c" |
t3chguy
approved these changes
Mar 2, 2023
Member
Author
|
Still getting this, something is still not right with the lockfile: |
Member
Author
|
I can't understand why I'm still getting: After my latest commit did a |
Member
Author
|
Ah, I think it's running against a different commit so it can compare with this one. Given that the main Static Analysis action passed, I think this PR is fine. Merging and keeping an eye in case I'm wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives access to the new widget customisations e.g. matrix-org/matrix-react-sdk#10121
This change is marked as an internal change (Task), so will not be included in the changelog.