Skip to content

Bump @matrix-org/react-sdk-module-api to 0.0.4#24642

Merged
andybalaam merged 7 commits intodevelopfrom
andybalaam/bump-module-api-to-0.0.4
Mar 2, 2023
Merged

Bump @matrix-org/react-sdk-module-api to 0.0.4#24642
andybalaam merged 7 commits intodevelopfrom
andybalaam/bump-module-api-to-0.0.4

Conversation

@andybalaam
Copy link
Copy Markdown
Member

@andybalaam andybalaam commented Feb 24, 2023

This gives access to the new widget customisations e.g. matrix-org/matrix-react-sdk#10121


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Tasks for the team like planning label Feb 24, 2023
@andybalaam andybalaam requested a review from a team as a code owner February 24, 2023 12:42
@andybalaam andybalaam requested a review from t3chguy February 24, 2023 12:42
@andybalaam andybalaam marked this pull request as draft February 24, 2023 13:16
@maheichyk
Copy link
Copy Markdown
Contributor

@andybalaam it seems that the pipeline should be fine if restarted, so maybe could try to merge

@andybalaam andybalaam marked this pull request as ready for review March 1, 2023 10:29
Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like no bumping actually happened given no yarn.lock change

@andybalaam
Copy link
Copy Markdown
Member Author

Good point @t3chguy . After much fighting with yarn install trying to prevent the wrong matrix-events-sdk version re-appearing, I realised I needed #24708 first, then I can fix this one.

@andybalaam andybalaam requested a review from t3chguy March 1, 2023 14:34
yarn.lock Outdated
"matrix-react-sdk@github:matrix-org/matrix-react-sdk#develop":
version "3.67.0"
resolved "https://codeload.github.com/matrix-org/matrix-react-sdk/tar.gz/da2fcdd3462bfcc3ee0033f2d5303942521e1df5"
resolved "https://codeload.github.com/matrix-org/matrix-react-sdk/tar.gz/4f1e5a71dec65258f5295f7d60d2e733391d304c"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong.

@andybalaam andybalaam requested a review from t3chguy March 2, 2023 14:24
@andybalaam andybalaam enabled auto-merge (squash) March 2, 2023 14:24
@andybalaam andybalaam disabled auto-merge March 2, 2023 14:28
@andybalaam
Copy link
Copy Markdown
Member Author

Still getting this, something is still not right with the lockfile:

[current branch] Install Dependencies
  Installing using yarn --frozen-lockfile
  /usr/local/bin/yarn --frozen-lockfile
  yarn install v1.22.19
  [1/4] Resolving packages...
  error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
  info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
  Error: The process '/usr/local/bin/yarn' failed with exit code 1

@andybalaam
Copy link
Copy Markdown
Member Author

I can't understand why I'm still getting:

/usr/local/bin/yarn --frozen-lockfile
  yarn install v1.22.19
  [1/4] Resolving packages...
  error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.

After my latest commit did a yarn install and that command works for me locally.

@andybalaam
Copy link
Copy Markdown
Member Author

Ah, I think it's running against a different commit so it can compare with this one.

Given that the main Static Analysis action passed, I think this PR is fine. Merging and keeping an eye in case I'm wrong.

@andybalaam andybalaam merged commit 9e5ed11 into develop Mar 2, 2023
@andybalaam andybalaam deleted the andybalaam/bump-module-api-to-0.0.4 branch March 2, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants