-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Expanding a really large Event List Summary causes it to spontaneously collapse again #9192
Copy link
Copy link
Closed
matrix-org/matrix-react-sdk
#7915Labels
A-TimelineO-UncommonMost users are unlikely to come across this or unexpected workflowMost users are unlikely to come across this or unexpected workflowS-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundSeverely degrades major functionality or product features, with no satisfactory workaroundT-DefectZ-t3chguy
Description
Reproduction steps
- have a room that has experienced LOT of membership events (in this case, 700)
- expand the summary (MELS), possibly scroll up, watch it get replaced and thus collapse again
Notes:
- presumably expanding it triggers backpagination or something which causes a rerender which then renders a collapsed MELS
- in theory not a horribly hard thing to fix, just needs a cache in the TimelinePanel to track which events are shown in a MELS and use that cache when building MELSes so that when you back paginate you don't change its key causing React to throw away the existing state
- to put more words on the cause, we have to key every tile in the timeline with a unique string, for MELS we use the event ID of the first event shown, the issue with that is, when backpaginating, that first event may change (an older event may be found) so then the key changes and React throws the whole subtree away
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-TimelineO-UncommonMost users are unlikely to come across this or unexpected workflowMost users are unlikely to come across this or unexpected workflowS-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundSeverely degrades major functionality or product features, with no satisfactory workaroundT-DefectZ-t3chguy
Type
Fields
Give feedbackNo fields configured for issues without a type.