Superfluous space inserted when entering a '

[rhaamo]

Description

When entering a ' there is a space inserted right before in the input prompt.

Steps to reproduce

• In a chat
• Type like that's
• Expect to see that's
• See that 's instead
  

Version information

• Platform: web (in-browser)
• Browser: Firefox Nightly (63.0a1, no stable to test)
• OS: Ubuntu
• URL: my own deployment of riot, reproduced with v0.16.0 and v0.16.1-rc.1

Markdown enabled or no doesn't change anything.
My layout is "English (US, intl., with dead keys)"
I used the firefox Profile Manager to create a blank one, logged to my riot, still have the issue.

[lampholder]

There are a couple of other dead keys related bugs:

• Dead keys stopped working in the desktop version #7124
• Making quotes or apostrophes with deadkeys doesn't work #7149

My problem is I don't know enough about this keyboard layout to reproduce the problems.

So, to try and create the right test environment, here's what I'm doing:

• On Ubuntu LTS 16.04
• Terminal: $ sudo dpkg-reconfigure keyboard-configuration
• Choose: Generic 105-key (Intl) P
• Choose: English (US)
• Choose: English (US) - English (US, international with dead keys)
• Choose key to function as AltGr: The default for the keyboard layout
• Choose compose key: No compose key
• Choose contral+alt+backspace to terminate X server: No

Then:

• Go to riot electron
• Select composer
• Type that's by pressing the keys: thatAltGr+'s
• Pressing carriage return to submit the message to riot

When I do this, I see that's exactly as it's meant to be seen - no additional spaces.

So - what's different between my test setup and what you're doing? If you can highlight the differences then we can get a reproducable problem and figure out what needs doing for a fix :D

Thanks!

[rhaamo]

Everything is same here, I just don't use the electron but web app.

However I type my ' by pressing ' then space, using AltGr' it works, just not the other method.

Same issue with ` too.

[rien]

I am also having this issue. When trying to insert a ' or " using the ' + space method. This is how dead keys work.

Usually, the diacritic itself can be generated as an isolated character by pressing the dead key followed by space; so a plain grave accent can be typed by pressing ` and then Space. This legacy behavior is newly replaced with a more efficient one with respect to the use of combining diacritics following the Unicode Standard. The combining diacritic is then obtained with Space, while a spacing form of the diacritic is inserted with No-Break Space (typically ⇧ Shift+Space or AltGr+Space).

[turt2live]

@rhaamo have you seen this on recent versions of Riot (0.17 or higher)? I'm a little concerned it is a duplicate of #7124 however #7124 says that it doesn't happen on Firefox.

[rhaamo]

I definitely had this issue on Firefox and was the case with 0.17.0 too.

However in the mean time I upgraded from Ubuntu LTS to the latest "stable" and I can't reproduce the issue (still sometimes the '" etc. acts weirdly).

So... I don't really know, that issue have been affecting a bunch of people and some works where some other using the same setup doesn't.

Perhaps something on gnome/gtk input handling side was broken and updating fixed it.

I might get back to LTS because the "stable" is causing me issues (unrelated to riot) so I will look if it's again an issue after reinstalling.

[turt2live]

I'll give it a try on 18.04 and see what happens. My testing with 18.10 seems to show it is fixed, so it might indeed be a package problem.

[turt2live]

I think this might be an 18.04 issue at the very least: I can't get the dead keys to work in any application. In 18.10 everything is fine, but in 18.04 is definitely broken. I tried with US International (with dead keys) and Spanish (with dead tilde).