Construct formatted body from replied event#6155
Merged
aringenbach merged 4 commits intodevelopfrom Jun 7, 2022
Merged
Conversation
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ixx4kF |
giomfo
reviewed
May 16, 2022
Riot/Modules/MatrixKit/Utils/EventFormatter/MXKEventFormatter.m
Outdated
Show resolved
Hide resolved
aringenbach
force-pushed
the
aringenbach/construct_replies_from_replied_event
branch
from
969ef05 to
1d93f63
Compare
aringenbach
requested review from
a team,
gileluard and
phloux
and removed request for
a team
gileluard
approved these changes
Jun 3, 2022
Contributor
gileluard
left a comment
gileluard
left a comment
There was a problem hiding this comment.
LGTM. If you can just apply this small tweak.
Riot/Modules/MatrixKit/Utils/EventFormatter/MXKEventFormatter.m
Outdated
Show resolved
Hide resolved
Co-authored-by: Gil Eluard <gile@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial implementation of rich replies
It constructs the reply body directly from the related event, but only if it is available in the local DB.
Replies to unavailable events will fallback to the current behaviour.
It is therefore a partial fix for #3828 #3517 #4586 #5479 #5823
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-02.at.15.48.04.mp4