Merged
Conversation
Member
stefanceriu
commented
Nov 26, 2021
- Added support for rendering polls in the timeline.
- Introduced new poll bubble cells that render a SwiftUI component on the existing timeline.
- Integrated the already existing poll builder and aggregator into the PollTimeline coordinator
- Added polls labs setting
- increased edit form texts max length
- linked creation form to poll start events
Member
Author
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ndweSQ |
|
@stefanceriu The build has expired :/ |
gaelledel
suggested changes
Nov 30, 2021
Member
Author
I triggered a new one, can you try again please? |
pixlwave
reviewed
Dec 2, 2021
Member
There was a problem hiding this comment.
Very nice! Sorry for number of comments (I seem to always say this 🙄). 2 larger comments:
- More doc comments please 🥺
- With the
PollTimelineProviderbeing a singleton, what happens when you push another room on top of the existing room and then navigate back (e.g. for a preview or a thread)?
RiotSwiftUI/Modules/Room/PollEditForm/Coordinator/PollEditFormCoordinator.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollEditForm/Coordinator/PollEditFormCoordinator.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/PollTimeline/Coordinator/PollTimelineCoordinator.swift
Outdated
Show resolved
Hide resolved
Member
Author
|
pixlwave
reviewed
Dec 3, 2021
pixlwave
reviewed
Dec 3, 2021
RiotSwiftUI/Modules/Room/PollTimeline/Coordinator/PollTimelineCoordinator.swift
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
Dec 3, 2021
RiotSwiftUI/Modules/Room/PollTimeline/View/PollTimelineAnswerOptionButton.swift
Outdated
Show resolved
Hide resolved
pixlwave
approved these changes
Dec 3, 2021
dc62af5 to
1c919db
Compare
gaelledel
approved these changes
Dec 6, 2021
gaelledel
left a comment
There was a problem hiding this comment.
Amazing thank you for the changes! :)
SBiOSoftWhare
approved these changes
Dec 8, 2021
RiotSwiftUI/Modules/Room/PollTimeline/PollTimelineViewModel.swift
Outdated
Show resolved
Hide resolved
204e098 to
91108e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




