Improve the visual experience of joining a call#708
Merged
robintown merged 1 commit intoelement-hq:mainfrom Nov 3, 2022
Merged
Improve the visual experience of joining a call#708robintown merged 1 commit intoelement-hq:mainfrom
robintown merged 1 commit intoelement-hq:mainfrom
Conversation
robintown
force-pushed
the
join-polish
branch
2 times, most recently
from
596c3ab to
13af7a6
Compare
Because useMeasure always returns a width and height of zero on the first render, various call UI elements would flash in and out of existence or animate in from the wrong place when joining a call. This poses an accessibility issue, and is generally unpleasant.
robintown
force-pushed
the
join-polish
branch
from
13af7a6 to
2d5f413
Compare
dbkr
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
useMeasurealways returns a width and height of zero on the first render, various call UI elements would flash in and out of existence or animate in from the wrong place when joining a call. This poses an accessibility issue, and is generally unpleasant.Closes #569
Before
before.mp4
After
after.mp4