Unify LiveKit and Matrix connection states by toger5 · Pull Request #3611 · element-hq/element-call

toger5 · 2025-12-02T18:40:41Z

From internal discussions about this PR: https://matrix.to/#/!tDLCaLXijNtYcJZEey:element.io/$jPuIV8UAaCVC8IPEe8LaJPDbaZ85o6nnCdxVeQoMcx0?via=element.io&via=matrix.org&via=robin.town

We have understood the actual model of the state. (They are NOT simply linear but change how many dimensions they have dependent on the state)

1D: [loading transport + create LK Room]

3D:[connectingToLkRoom, createTracks, matrixState]This one is the thing that makes it complicated. We can create tracks before we are connected to the lk room or after (!! connected to lk room is not the sama as lk room created) so this is the thing that made it feel so wrong with the prev appraoch!

2D:[publishing, matrixState]We can only start the publishing states once both independent prev states connectingToLkRoom, createTracks are ready.

We have found some good names for the states (some are still pending)

We have noticed that the {state: string, error: Error} structure is not ideal -> a simple "or-Type" is a lot simpler and more elegant State | Error (especially with the dimension changes)

src/state/CallViewModel/remoteMembers/Connection.ts

src/state/CallViewModel/localMember/Publisher.ts

src/state/CallViewModel/localMember/LocalMember.ts

toger5 · 2025-12-09T16:35:13Z

src/state/CallViewModel/localMember/LocalMember.ts

  );

-  // Keep matrix rtc session in sync with localTransport$, connectRequested$ and muteStates.video.enabled$
+  // inform the widget about the connect and disconnect intent from the user.


where does this come from.

this was pulled to make the join rtc session functions sync.

BillCarsonFr

We've done a live review of that together, so it is fine by me.
Just some minor comments, but no blockers

BillCarsonFr · 2025-12-11T14:28:08Z

playwright/fixtures/widget-user.ts

  try {
-    await expect(continueButton).toBeVisible({ timeout: 5000 });
+    await expect(continueButton).toBeVisible({ timeout: 700 });
+    // why do we need to put in the passwor if there is a continue button?


I think this can be removed now? Looks like it was some old onboarding UI from web that is not needed anymore?

cool that makes sense. I was wondering in what cases it would be used.

remove all continueButton related code.

BillCarsonFr · 2025-12-11T14:29:42Z

playwright/fixtures/widget-user.ts

    page.getByRole("heading", { name: `Welcome ${username}` }),
  ).toBeVisible();
+
+  // Dismiss incompatible browser toast


Can we add more test to be sure that we really dismiss the popup we think we dismiss (check the title)?

This is fixed by updating playwright, right? is it really needed?

It helps us save time if we are slow with merging renovate and need to debug why our test fail.

src/room/GroupCallView.tsx

BillCarsonFr · 2025-12-11T14:33:05Z

src/room/InCallView.tsx

  const mediaDevices = useMediaDevices();
  const trackProcessorState$ = useTrackProcessorObservable$();
  useEffect(() => {
+    logger.info("START CALL VIEW SCOPE");


add some prefix to the log until we have proper prefixed logger?
Something like [InCallView]

I added a proper logger.

src/room/LobbyView.tsx

github-actions bot deployed to Netlify December 2, 2025 18:42 View deployment

Unify LiveKit and Matrix connection states

2e646bf

toger5 force-pushed the toger5/connection-state-refactor branch from 2e5e6b5 to 2e646bf Compare December 2, 2025 18:49

github-actions bot deployed to Netlify December 2, 2025 18:50 View deployment

toger5 added 3 commits December 3, 2025 10:04

cleanup

88721be

ideas

7c40b0e

cleanup and tests

bf80136

toger5 marked this pull request as ready for review December 9, 2025 14:24

toger5 requested a review from a team as a code owner December 9, 2025 14:24

toger5 requested a review from robintown December 9, 2025 14:24

github-actions bot deployed to Netlify December 9, 2025 14:24 View deployment

toger5 added the PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. label Dec 9, 2025

toger5 commented Dec 9, 2025

View reviewed changes

src/state/CallViewModel/remoteMembers/Connection.ts Outdated Show resolved Hide resolved

toger5 commented Dec 9, 2025

View reviewed changes

src/state/CallViewModel/localMember/Publisher.ts Outdated Show resolved Hide resolved

toger5 commented Dec 9, 2025

View reviewed changes

src/state/CallViewModel/localMember/LocalMember.ts Outdated Show resolved Hide resolved

toger5 commented Dec 9, 2025

View reviewed changes

toger5 added 3 commits December 9, 2025 17:36

fix lint

7af89b4

Update LocalMember.ts

0ebc607

Merge branch 'livekit' into toger5/connection-state-refactor

ef2f53c

github-actions bot deployed to Netlify December 10, 2025 12:50 View deployment

fix playwright tests

6efce23

github-actions bot deployed to Netlify December 10, 2025 17:51 View deployment

fix tests.

1941fc9

github-actions bot deployed to Netlify December 10, 2025 18:14 View deployment

fix test not checking for livekit connection state anymore.

667a3d0

github-actions bot deployed to Netlify December 10, 2025 18:19 View deployment

lots of error logging and fixing playwright

b380532

github-actions bot deployed to Netlify December 10, 2025 20:15 View deployment

fix lints

8dac036

github-actions bot deployed to Netlify December 10, 2025 20:18 View deployment

fix connection tests

e626698

github-actions bot deployed to Netlify December 10, 2025 20:24 View deployment

fix lint

aabd760

github-actions bot deployed to Netlify December 10, 2025 20:26 View deployment

fix playwright incompatible browser toast

170a38c

github-actions bot deployed to Netlify December 11, 2025 10:31 View deployment

update playwright so that we do not even need the dismiss anymore.

328cc71

github-actions bot deployed to Netlify December 11, 2025 10:33 View deployment

BillCarsonFr approved these changes Dec 11, 2025

View reviewed changes

remove duplicated connecting state and update Test setup

08306d6

github-actions bot deployed to Netlify December 11, 2025 15:05 View deployment

fix lint

9a7e797

github-actions bot deployed to Netlify December 11, 2025 15:19 View deployment

fix logger and dismiss button presses

207b161

github-actions bot deployed to Netlify December 11, 2025 16:19 View deployment

remove page.pause

8225e4f

github-actions bot deployed to Netlify December 11, 2025 16:23 View deployment

remove continue button things

7edc97b

github-actions bot deployed to Netlify December 11, 2025 16:26 View deployment

toger5 merged commit cf453ba into livekit Dec 11, 2025
19 checks passed

Conversation

toger5 commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

toger5 commented Dec 2, 2025 •

edited

Loading