Skip to content

fix: The handset mode overlay is visible a split second for every call #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillCarsonFr merged 8 commits into from
Dec 4, 2025
Merged

fix: The handset mode overlay is visible a split second for every call #3606

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e04fd9
fix: The handset mode overlay is visible a split second for every call
BillCarsonFr Dec 2, 2025
0ed7194
fix: earpiece overlay not showing + playwright test!
BillCarsonFr Dec 3, 2025
bcb2b36
keep livekit 1.9.4 as the latest is breaking the dev backend
BillCarsonFr Dec 3, 2025
c7491c3
move fixture to correct folder
BillCarsonFr Dec 3, 2025
5d55f83
Merge branch 'livekit' into valere/fix_transiant_earpiece_overlay
BillCarsonFr Dec 4, 2025
940c787
review: quick renaming
BillCarsonFr Dec 4, 2025
7a2c1af
review: use simple transition instead of keyframe
BillCarsonFr Dec 4, 2025
71bf55f
also test that video is muted when earpiece overlay is on
BillCarsonFr Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions src/room/EarpieceOverlay.module.css
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@toger5 toger5 Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its nice to see that simplifying the css improved it.

Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,22 @@
position: fixed;
z-index: var(--call-view-overlay-layer);
inset: 0;
display: none;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
gap: var(--cpd-space-2x);
}

@keyframes fade-in {
from {
opacity: 0;
}
to {
opacity: 1;
}
transition: opacity 200ms;
}

.overlay[data-show="true"] {
display: flex;
animation: fade-in 200ms;
}

@keyframes fade-out {
from {
opacity: 1;
}
to {
opacity: 0;
}
opacity: 1;
}

.overlay[data-show="false"] {
animation: fade-out 130ms forwards;
opacity: 0;
pointer-events: none;
transition-duration: 130ms;
}

.overlay::before {
Expand Down