fix: Automatically switch to spotlight if remote screenshare#3601
Merged
BillCarsonFr merged 2 commits intolivekitfrom Dec 1, 2025
Merged
fix: Automatically switch to spotlight if remote screenshare#3601BillCarsonFr merged 2 commits intolivekitfrom
BillCarsonFr merged 2 commits intolivekitfrom
Conversation
toger5
reviewed
Dec 1, 2025
| }); | ||
| }); | ||
|
|
||
| it.skip("screen sharing activates spotlight layout", () => { |
Contributor
There was a problem hiding this comment.
oh wow this was actually skipped so we even had a test for that regression. This is super nice to see!
toger5
reviewed
Dec 1, 2025
| ); | ||
|
|
||
| const gridModeUserSelection$ = new Subject<GridMode>(); | ||
| const gridModeUserSelection$ = new BehaviorSubject<GridMode>("grid"); |
Contributor
There was a problem hiding this comment.
while at it can we move
const setGridMode = (value: ..
right next to the BehaviorSubject?
toger5
approved these changes
Dec 1, 2025
Half-Shot
approved these changes
Dec 1, 2025
Member
Half-Shot
left a comment
Half-Shot
left a comment
There was a problem hiding this comment.
This makes sense to me 👍 , more readable now too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3588
Not sure when it did regress, the main change is to make
gridModeUserSelection$emit an initial value (changed it from Subject, to BehaviorSubject`).If it is no initial value,
gridMode$is directly set togridwithout doing theswitchmapin the chain that is checking the current screenShare state in order to override the userChoise tospotlightwhen there is a screen share.The test for that behavior was skipped, it is now enabled again