Skip to content

Fix: never stop ring feedback on the sender side.#3502

Merged
toger5 merged 2 commits intolivekitfrom
toger5/fix-ring-never-stops
Sep 19, 2025
Merged

Fix: never stop ring feedback on the sender side.#3502
toger5 merged 2 commits intolivekitfrom
toger5/fix-ring-never-stops

Conversation

@toger5
Copy link
Copy Markdown
Contributor

@toger5 toger5 commented Sep 19, 2025

Make ring$ a behavior and add code comments to justify/explain the change.

Signed-off-by: Timo K [email protected]

Copy link
Copy Markdown
Member

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tick as per the other PR

Copy link
Copy Markdown
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos for the test

@toger5 toger5 merged commit 317b2dc into livekit Sep 19, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bug-Fix Release note category. A PR that fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants