Return to normal state when time limit reached#313
Merged
Conversation
Handle mouseup events anywhere so the button releases if you move the cursor out of the button & release. Likewsie for window losing focus.
we already do this in usePTT
robertlong
approved these changes
May 6, 2022
Contributor
robertlong
left a comment
robertlong
left a comment
There was a problem hiding this comment.
I'd make that one small change, otherwise looks great 👍
src/room/usePTT.js
Outdated
| const startTalking = useCallback(() => { | ||
| const startTalking = useCallback(async () => { | ||
| setState((prevState) => ({ ...prevState, pttButtonHeld: true })); | ||
| setUnmuteError(null); |
Contributor
There was a problem hiding this comment.
I might store the unmuteError in state instead of it's own useState.
Member
Author
There was a problem hiding this comment.
OK - I flipped back & forth between staying consistent and splitting it out since merging with prevState each time seemed quite boilerplate-y, but since it's already setting other state in one case anyway maybe consistency is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #311
Fixes #297