Don't create dev certificate when using Azure trusted signing#27
Open
daniel-weisse wants to merge 1 commit intoelectron-userland:mainfrom
Open
Don't create dev certificate when using Azure trusted signing#27daniel-weisse wants to merge 1 commit intoelectron-userland:mainfrom
daniel-weisse wants to merge 1 commit intoelectron-userland:mainfrom
Conversation
Signed-off-by: Daniel Weiße <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure artifact signing uses a dll and json config file to retrieve the certificates required to sign artifacts with
signtool.exe.The configuration is passed to
signtool.exeusing the/dliband/dmdfflags.No certificate is explicitly passed using the
/fflag.The MSIX packager however automatically generates a dev certificate if none is provided and adds it to the arguments for
signtool.exe, effectively blocking artifact signing.This PR changes the dev cert creation behavior by simply not creating one if the parameters for
signtool.execontains the/dlibflagFixes #24