fix: pnpm "Invalid string length" errors during node module collection#9470
Merged
mmaietta merged 1 commit intoelectron-userland:masterfrom Dec 28, 2025
Conversation
🦋 Changeset detectedLatest commit: 30153c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
839d598 to
8554741
Compare
8554741 to
30153c6
Compare
Contributor
|
very good catch. LGTM |
beyondkmp
approved these changes
Dec 28, 2025
mmaietta
approved these changes
Dec 28, 2025
Contributor
Author
|
Thanks, although I'm not sure what is causing the test failure. It seems unrelated to the change I made. |
Collaborator
|
It's a flaky test; re-running the tests. Not sure why it's minorly flaky, but also not sure if it's worthwhile to solve for that with the complexity of install+run+serve/autoupdate+relaunch within a docker container. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9469
electron-builder calls
pnpm list --prod --json --depth Infinity --longto collect node modules with pnpm. My project has many dependencies, so this command fails with the following error:Removing
--longresolves this error. This flag adds the following fields to the output:descriptionlicenseauthorhomepagerepositoryelectron-builder doesn't appear to consume any of these fields, so
--longcan safely be removed.