fix: validate package version when traversing directories in search of a matching node module#9424
Merged
Conversation
…f a matching node module
🦋 Changeset detectedLatest commit: 91e8363 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semvervalidation has been added to make sure the correct module path is selected. This is particularly relevant when there are two versions (one hoisted and the other not) and only one of them is a prod dep => fixes builds broken since v26.3.0 #9394Proxyfor dot-notation access into each of the subcaches within the class.Additional note:
Test snapshots were reverted back to 26.2.0 and then the fixed node module collector logic here was run against those pre-corepack snapshots. This was done to start from a "clean" slate
Should also fix #9423