Skip to content

chore(deps): unpinning semver and updating it#9349

Merged
mmaietta merged 2 commits into
electron-userland:masterfrom
panther7:not-pinning-semver
Dec 6, 2025
Merged

chore(deps): unpinning semver and updating it#9349
mmaietta merged 2 commits into
electron-userland:masterfrom
panther7:not-pinning-semver

Conversation

@panther7
Copy link
Copy Markdown
Contributor

@panther7 panther7 commented Nov 13, 2025

ref #9301

Why?

If one project has the version "7.7.3" and another project has "7.7.2", the bundle package (e.g., Webpack) will include both versions, 7.7.3 and 7.7.2. However, if a project uses ~ or ^, the build will include only one version in the bundle.
This is just one example. If all dependencies have strict versions, all modules with different versions will be included in the bundle. This creates a cascading issue.
If it is not necessary to require a specific version (e.g., for bug fixes, security, etc.), I see no reason to do so.
Using the tilde (~) is a good compromise.

@mmaietta

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 13, 2025

🦋 Changeset detected

Latest commit: 12c8481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
app-builder-lib Patch
electron-updater Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Nov 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedtar@​6.2.19810010085100
Addedsemver@​7.7.310010010089100

View full report

@panther7 panther7 changed the title chore(deps): upinning semver chore(deps): unpinning semver and updating it Nov 21, 2025
mmaietta
mmaietta previously approved these changes Dec 4, 2025
@panther7
Copy link
Copy Markdown
Contributor Author

panther7 commented Dec 5, 2025

any update with this?

@mmaietta
Copy link
Copy Markdown
Collaborator

mmaietta commented Dec 5, 2025

Trying to merge it but every time new commits are pushed, I have to requeue all the CI tests. No more pushes and I can get this into the next release 😅

@panther7
Copy link
Copy Markdown
Contributor Author

panther7 commented Dec 5, 2025

Ok, only rebase. :-)

Let's go.

@mmaietta mmaietta merged commit e043df5 into electron-userland:master Dec 6, 2025
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants