fix: auto-update powershell script#9232
Merged
mmaietta merged 4 commits intoelectron-userland:masterfrom Aug 13, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d62549a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
reviewed
Aug 1, 2025
This was referenced Aug 13, 2025
Merged
This was referenced Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the
Get-AuthenticodeSignaturecommand fails, in the error handler there is an additionalConvertTo-Json testcommand that should be called in the same way asGet-AuthenticodeSignature. Without this,Get-AuthenticodeSignaturecould fail simply due to the workarounds used (usingshell:truechcp 65001 >NUL#7230 and resettingPSModulePath#8051), which is unintended behavior.After this fix, when the workarounds fail, the
ConvertTo-Json testcommand will also fail (with the messageIgnoring signature validation due to unsupported PowerShell version) and the update will be installed.