Skip to content

Conversation

@BrandonXLF
Copy link
Contributor

Per the first annotation at https://www.electron.build/publish, it should be possible to disable publishing to the Snap Store by explicitly not listing Snap Store in snap.publisher. This was possible until #7908.

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: d5f3fd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BrandonXLF BrandonXLF marked this pull request as draft February 24, 2025 06:21
@mmaietta mmaietta changed the title allow publishing to Snap Store to be disabled with snap specific publish options fix: allow publishing to Snap Store to be disabled with snap specific publish options Feb 24, 2025
@mmaietta
Copy link
Collaborator

Please see build errors. Quick excerpt:

Error: packages/app-builder-lib/src/targets/snap.ts(275,5): error TS2322: Type '{ provider: string; }' is not assignable to type 'SnapStoreOptions'.
  Types of property 'provider' are incompatible.
    Type 'string' is not assignable to type '"snapStore"'.
Error: packages/app-builder-lib/src/targets/snap.ts(298,3): error TS2322: Type '{ provider: string; }' is not assignable to type 'SnapStoreOptions'.
  Types of property 'provider' are incompatible.
    Type 'string' is not assignable to type '"snapStore"'.

@BrandonXLF BrandonXLF marked this pull request as ready for review February 24, 2025 18:02
@mmaietta
Copy link
Collaborator

Wait, I'm not sure why HoistedNodeModuleTest snapshot needed to be updated. Let me test on latest master and see if some fixture dependency changed as I'd like to isolate the changes of this PR to snaps if possible

@BrandonXLF
Copy link
Contributor Author

Wait, I'm not sure why HoistedNodeModuleTest snapshot needed to be updated. Let me test on latest master and see if some fixture dependency changed as I'd like to isolate the changes of this PR to snaps if possible

Sounds good, I'm also quite confused by it.

@mmaietta mmaietta merged commit 67b6f71 into electron-userland:master Feb 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants