Skip to content

fix: allow usage of node-linker=hoisted with pnpm #8885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 22, 2025
Merged

fix: allow usage of node-linker=hoisted with pnpm #8885

merged 8 commits into from
Feb 22, 2025

Conversation

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Feb 22, 2025 •
edited
Loading

Fixes: #8881

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: dea5e74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta mentioned this pull request Feb 22, 2025
Closed
beyondkmp
beyondkmp reviewed Feb 22, 2025
View reviewed changes
beyondkmp
beyondkmp previously approved these changes Feb 22, 2025
View reviewed changes
@mmaietta mmaietta marked this pull request as ready for review February 22, 2025 03:36
beyondkmp
beyondkmp reviewed Feb 22, 2025
View reviewed changes
beyondkmp
beyondkmp reviewed Feb 22, 2025
View reviewed changes
@xyloflake
Copy link
Contributor

xyloflake commented Feb 22, 2025

I'll have a look

xyloflake
xyloflake reviewed Feb 22, 2025
View reviewed changes
xyloflake
xyloflake suggested changes Feb 22, 2025
View reviewed changes
xyloflake
xyloflake approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@xyloflake xyloflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmaietta
Copy link
Collaborator Author

mmaietta commented Feb 22, 2025

Thanks for the review @xyloflake and @beyondkmp !

@mmaietta mmaietta merged commit 4cc475e into master Feb 22, 2025
17 checks passed
@mmaietta mmaietta deleted the support-node-linker-hoisted branch February 22, 2025 14:57
This was referenced Feb 22, 2025
Merged
Closed
Open
Open
@mickythompson mickythompson mentioned this pull request Nov 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@beyondkmp beyondkmp beyondkmp left review comments

@xyloflake xyloflake xyloflake approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app-builder-lib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Cannot find module '.../package.json'

4 participants

@mmaietta @xyloflake @beyondkmp