fix: Remove adapter if core22 is set as base on snapcraft#7378
Merged
mmaietta merged 2 commits intoelectron-userland:masterfrom Jan 23, 2023
filfreire:fix/issue-7372
Merged
fix: Remove adapter if core22 is set as base on snapcraft#7378mmaietta merged 2 commits intoelectron-userland:masterfrom filfreire:fix/issue-7372
mmaietta merged 2 commits intoelectron-userland:masterfrom
filfreire:fix/issue-7372
Conversation
🦋 Changeset detectedLatest commit: d467eac The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mmaietta
reviewed
Jan 17, 2023
| snap.base = options.base | ||
| // from core22 onwards adapter is legacy | ||
| if (snap.base === "core22") { | ||
| delete appDescriptor.adapter |
Collaborator
There was a problem hiding this comment.
Do we need to future-proof this for core22+? This feels too hardcoded to me. Perhaps we can extract the number from core__ and compare >= 22, what are your thoughts?
Contributor
Author
There was a problem hiding this comment.
Agreed. We can change it to something like Number(snap.base.split("core")[1]) >= 22 instead?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7372
cc @mmaietta