Skip to content

fix(app-builder-lib): export missing TS types - #7297

Merged
mmaietta merged 1 commit into
electron-userland:masterfrom
t3chguy:patch-1
Dec 1, 2022
Merged

fix(app-builder-lib): export missing TS types#7297
mmaietta merged 1 commit into
electron-userland:masterfrom
t3chguy:patch-1

Conversation

@t3chguy

@t3chguy t3chguy commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

Fixes #7296
Based on #6692

@changeset-bot

changeset-bot Bot commented Dec 1, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8d65bf5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Dec 1, 2022

Copy link
Copy Markdown

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8d65bf5
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/638826d62ceef10008cd1979
😎 Deploy Preview https://deploy-preview-7297--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta
mmaietta merged commit 9ce7448 into electron-userland:master Dec 1, 2022
@t3chguy
t3chguy deleted the patch-1 branch December 1, 2022 20:31
@t3chguy

t3chguy commented Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

@mmaietta any chance to get a 23.x patch release containing this fix?

Thanks

@mmaietta

mmaietta commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Sorry, unfortunately, the way the CI/CD automation works with @changesets package, I have no idea how to roll out a patch for a previous version. It's stuck in pre (alpha) until we promote it to a proper v24 release. Are you not able to use 24.0.0-alpha.5?

@t3chguy

t3chguy commented Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

We've pinned app-builder-lib back to 22.x as we only use it for getElectronVersion whilst having the rest of electron-builder at 23.6.0 - element-hq/element-desktop#558 moves us wholly to 24.x-alpha but will be blocked until alpha stabilises.

If it is a faff then don't worry about it, initially I thought mac.notarize support was present in 23.6.0 and us pinning back app-builder-lib caused schema validation issues but in fact it was added to scheme.json in 00d0dbc (alpha13) and the docs are at fault for including it without stating what version it is available from (whilst listing v23.6.0 in the top right github links) https://www.electron.build/configuration/mac

@github-actions github-actions Bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

app-builder-lib - TS2304: Cannot find name 'Node' since v23

2 participants