fix: Always cleanup replication slots on graceful shutdown #3458
+47
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conditional checks in Connection.Manager.terminate/2 to ensure replication slots and publications are always cleaned up during graceful shutdown, preventing resource leaks during deployment cycles. Fixes electric-sql#3284
icehaunter
requested changes
Nov 19, 2025
Contributor
icehaunter
left a comment
icehaunter
left a comment
There was a problem hiding this comment.
Unfortunately dropping a slot always like that means Electric can never continue, so any on-disk state will be invalid on startup, dropping all shapes.
I'm actually unsure what you meant by the original issue, @balegas - are we moving to transient state only?
Contributor
|
It is currently undocumented but you an set an environment variable As @icehaunter pointed out, cleaning up the slot means you cannot recover any data, so the above might be what you need. |
Contributor
|
Agree with both. way to achieve this is to use the temporary slot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conditional checks in Connection.Manager.terminate/2 to ensure replication slots and publications are always cleaned up during graceful shutdown, preventing resource leaks during deployment cycles.
Fixes #3284