Specify MD5 as the digest to create a key from the passphrase. #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ards compatibility)
Owner
|
Hey @damaestro! There's no automated migration in the upstream libraries, just a change in the default. As long as it's hard-coded in the clean/smudge filter scripts, we can also change the transcrypt default settings to match upstream, but I'll probably do that over a period of time after this PR is merged and a new release has been cut, in order to provide time for people to migrate to the explicit versions of the script and not break things moving forward. I'll think about if it would make sense to also add an option flag for setting the digest type at that time. Thanks for the PR, I've already pushed your changes to the master branch and will cut a new release shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #40 by setting the digest to MD5 for this operation. The question to be raised is should there be automatic migration to a different digest in the later versions of openssl? Is this being hardcoded a bad thing?