Add security list item #1492
Open
Add security list item #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-benoit
force-pushed
the
add_security_list_item_1
branch
from
434cb47 to
dea7d64
Compare
nick-benoit
force-pushed
the
add_security_list_item_1
branch
from
dea7d64 to
65879ca
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for managing Kibana security list items through the new elasticstack_kibana_security_list_item resource. The implementation depends on the security list functionality (PR #1489) and includes both the security list and list item resources to enable end-to-end testing. Once the security list PR is merged, the squashed commit will be removed to prevent conflicts.
Key changes include:
- Implementation of CRUD operations for security list items
- Support for optional metadata and custom IDs
- Comprehensive acceptance tests covering default and custom spaces
- Integration with the existing Kibana OAPI client infrastructure
Reviewed changes
Copilot reviewed 38 out of 40 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
provider/plugin_framework.go |
Registers the new security list and list item resources as experimental |
internal/kibana/security_list_item/*.go |
Core implementation of list item resource with CRUD operations and models |
internal/kibana/security_list/*.go |
Core implementation of security list resource with CRUD operations and models |
internal/clients/kibana_oapi/security_lists.go |
API client wrapper functions for security list and list item operations |
internal/kibana/security_list_item/testdata/**/*.tf |
Terraform test configurations for list item acceptance tests |
internal/kibana/security_list/testdata/**/*.tf |
Terraform test configurations for list acceptance tests |
examples/resources/**/*.tf |
Example usage documentation for both resources |
docker-compose.yml, .env, .github/workflows/test.yml |
Test environment configuration to enable experimental features |
CODING_STANDARDS.md |
Documents standard for deriving final state from read requests |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…tack into add_security_list_item_1
nick-benoit
force-pushed
the
add_security_list_item_1
branch
from
cf37599 to
c0d0bad
Compare
nick-benoit
commented
Nov 27, 2025
| MarkdownDescription: "Internal identifier for the resource (format: `<space_id>/<list_item_id>`).", | ||
| Computed: true, | ||
| }, | ||
| "list_item_id": schema.StringAttribute{ |
Contributor
Author
tobio
reviewed
Nov 28, 2025
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
Looking good, couple of minor things before we merge this one.
examples/resources/elasticstack_kibana_security_list_item/resource_ip.tf
Outdated
Show resolved
Hide resolved
Co-authored-by: Toby Brain <[email protected]>
…rm-provider-elasticstack into add_security_list_item_1
tobio
approved these changes
Nov 28, 2025
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
LGTM, way easier to review these independently. Thanks for splitting them up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Security List Item resource (docs)
Should be reviewed after Security List PR
This PR contains a squashed commit of the changes from the security list PR. This enables tests to run in this intermediate state. Once the security list PR is merged to master I will pull into this branch and drop the commit from this PR to prevent conflicts.
Rel: #1332