Allow configuring the process startup method to be used for creating thespian actors. #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for this is that to be able to use threads in subprocesses we have to prevemt using any kind of fork function.
fressi-elastic
changed the title
fressi-elastic
requested review from
a team,
Copilot,
gareth-ellis and
gbanasiak
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Rally actor system to use spawn instead of fork for subprocess creation, enabling thread usage in subprocesses. The main changes include:
- Adding process startup method configuration and validation
- Enhanced actor system detection and bootstrapping logic
- Comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| esrally/actor.py | Core implementation adding process startup method support, improved type annotations, and enhanced actor system detection |
| esrally/rally.py | Integration of process startup method configuration validation and actor system setup |
| esrally/types.py | Added new configuration keys for actor process startup method |
| tests/actor_test.py | Comprehensive test suite covering all actor system bootstrap scenarios and configurations |
| pyproject.toml | Added mypy override for the actor module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fressi-elastic
changed the title
gbanasiak
approved these changes
Aug 19, 2025
Contributor
gbanasiak
left a comment
gbanasiak
left a comment
There was a problem hiding this comment.
LGTM. I've left some minor comments and questions, but nothing blocking.
3 tasks
fressi-elastic
added a commit
to fressi-elastic/rally
that referenced
this pull request
Sep 8, 2025
…reating thespian actors. (elastic#1975)" This reverts commit 81abfc3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose for this is to be able to prevent using the fork function to be able to use threads for multipart downloads.