simplify x-pack/build.gradle #18381
Merged
simplify x-pack/build.gradle #18381
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label. Could you fix it @jsvd? 🙏
|
Collaborator
💚 Build Succeeded
|
Member
Author
|
@Mergifyio backport 9.2 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
There is no need to apply rubyUtils.gradle to `x-pack/build.gralde`, which defined the entire set of tasks from the former into the latter. This can lead to confusing situations like running `./gradlew downloadAndInstallJRuby` installing JRuby twice (once in project root and another in x-pack/) since gradle will run all tasks matching that name. (cherry picked from commit 3ca7395)
jsvd
added a commit
that referenced
this pull request
Nov 5, 2025
There is no need to apply rubyUtils.gradle to `x-pack/build.gralde`, which defined the entire set of tasks from the former into the latter. This can lead to confusing situations like running `./gradlew downloadAndInstallJRuby` installing JRuby twice (once in project root and another in x-pack/) since gradle will run all tasks matching that name. (cherry picked from commit 3ca7395) Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to apply rubyUtils.gradle to
x-pack/build.gralde, which defined the entire set of tasks from the former into the latter. This can lead to confusing situations like running./gradlew downloadAndInstallJRubyinstalling JRuby twice (once in project root and another in x-pack/) since gradle will run all tasks matching that name.Exhaustive test suite passed: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2803/steps/canvas