Skip to content

Conversation

@andsel
Copy link
Contributor

@andsel andsel commented Sep 16, 2025

Release notes

[rn:skip]

What does this PR do?

Minor change which fix Java settings class named to pattern <Name>Setting.

Why is it important/What is the impact to the user?

As a developer I want to use a cosisten naming policy on the setting classes.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • Boolean
  • SettingString and SettingNullableString
  • SettingNumeric
  • SettingInteger
  • SettingPositiveInteger

How to test this PR locally

Related issues

@andsel andsel self-assigned this Sep 16, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@andsel andsel changed the title Renamed Boolean -> BooleanSetting Rename Java settings classes to <Name>Setting Sep 16, 2025
@andsel andsel marked this pull request as ready for review September 16, 2025 16:33
@andsel andsel force-pushed the fix/java_setting_classes_renaming branch from a488a66 to 901aaab Compare September 17, 2025 08:04
@elastic-sonarqube
Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andsel

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit cd71a4b into elastic:main Sep 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Java Setting classes with names clashing with type system to counterparts with Setting prefix

3 participants