Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2025

Release notes

[rn:skip]

What does this PR do?

Re-works the loading of a text fixture to be less susceptible to encoding-related issues so that they work reliably on both posix systems and windows. The fixtures are lower-ascii, and should be processed in a line-oriented way.

Why is it important/What is the impact to the user?

N/A

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • observe that the exhaustive tests

How to test this PR locally

Fixes a test that was failing only on Windows, so from a Windows dev environment:

./gradlew :logstash-core:javaTests --tests "org.logstash.EventTest"

Related issues

Logs

EventTest > deserializeStringrefExtensionEnabled PASSED

-- exhaustive tests - Windows 2025

EventTest > deserializeStringrefExtensionDisabled PASSED

-- exhaustrive tests - Windows 2025


This is an automatic backport of pull request #18124 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Sep 5, 2025
@mergify mergify bot assigned yaauie Sep 5, 2025
@elastic-sonarqube
Copy link

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @yaauie

Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Clean and Green 🎉

@yaauie yaauie merged commit e719b5d into 9.0 Sep 5, 2025
12 checks passed
@yaauie yaauie deleted the mergify/bp/9.0/pr-18124 branch September 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants