github-actions: pin third-party actions #17420
+14
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,11 +22,11 @@ jobs: | |
| main: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@7886c6653556e1164c58a7603d88286b5f708293 # v1.228.0 | ||
| with: | ||
| ruby-version: '3.0' | ||
| - run: git config --global user.email "[email protected]" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,10 +12,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
|
Contributor
There was a problem hiding this comment. we need to confirm from docs-team if this will break anything.
Member
Author
There was a problem hiding this comment. checkout@v3 vs checkout@v4 should work, see https://github.com/actions/checkout/blob/main/CHANGELOG.md#v400 As far as i see it was a major change as they moved to |
||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 16.13.2 | ||
| cache: npm | ||
|
|
@@ -38,7 +38,7 @@ jobs: | |
| echo "::set-output name=LINT_RESULT::$LINT" | ||
|
|
||
| - name: Add PR comment | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| script: | | ||
|
|
@@ -58,7 +58,7 @@ jobs: | |
| } | ||
|
|
||
| - name: Throw error if linter fails | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const report = `${{ steps.run_docs_lint.outputs.LINT_RESULT }}` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,15 +13,15 @@ jobs: | |
| if: github.event.issue.pull_request | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
| - uses: actions-ecosystem/action-regex-match@9e6c4fb3d5e898f505be7a1fb6e7b0a278f6665b # v2.0.2 | ||
| id: regex-match | ||
| with: | ||
| text: ${{ github.event.comment.body }} | ||
| regex: '^@logstashmachine backport (main|[x0-9\.]+)$' | ||
| - if: ${{ steps.regex-match.outputs.group1 == '' }} | ||
| run: exit 1 | ||
| - name: Fetch logstash-core team member list | ||
| uses: tspascoal/get-user-teams-membership@39b5264024b7c3bd7480de2f2c8d3076eed49ec5 # v1.0.4 | ||
| id: checkUserMember | ||
| with: | ||
| username: ${{ github.actor }} | ||
|
|
@@ -32,14 +32,14 @@ jobs: | |
| if: ${{ steps.checkUserMember.outputs.isTeamMember == 'false' }} | ||
| run: exit 1 | ||
| - name: checkout repo content | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| ref: 'main' | ||
| - run: git config --global user.email "[email protected]" | ||
| - run: git config --global user.name "logstashmachine" | ||
| - name: setup python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.8 | ||
| - run: | | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to ping specific minor version?
setup-rubyrecommends using version and not to pin specific commit/release-version.Can you double check if this really we need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For third-party GH actions we need to follow the hardening:
⏫ , that's what InfoSec asked us to do.
So I took the latest
v1version at that time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependabotwill be the one actually bumping the version, see #17421