Migrate from tslint #33826
Merged
Migrate from tslint #33826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 26, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mistic
added
the
non-issue
Contributor
💚 Build Succeeded |
mikecote
approved these changes
Apr 4, 2019
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
I can confirm performance issues are fixed now 👍
w33ble
approved these changes
Apr 5, 2019
Contributor
w33ble
left a comment
w33ble
left a comment
There was a problem hiding this comment.
Exciting change! Everything looks good in Canvas as far as I can tell.
spalger
approved these changes
Apr 5, 2019
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
eliperelman
reviewed
Apr 5, 2019
Contributor
💚 Build Succeeded |
Contributor
Author
|
7.x: f062c97 |
weltenwort
added a commit
that referenced
this pull request
Apr 11, 2019
This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (#33826).
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Apr 11, 2019
…4942) This adds the generated typescript types to the `.eslintignore` file, because they started causing linter errors after the switch to `eslint` for typescript files (elastic#33826).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving away from
tslintto the typescript plugin foreslint. That would help us to keep moving on the effort of simplify our tooling removing one more dependency.Note that I tried to migrate all the legacy tslint rules we were using before to their counterparts on eslint. It was possible to do this in the major part of the rules, the exceptions were evaluated and we just drop them as they were not a blocker:
@typescript-eslint/explicit-member-accessibility-> Temporarily disabled waiting a PR to make it full legacy compatible feat(eslint-plugin): [member-accessibility] add more options typescript-eslint/typescript-eslint#322import/order-> Applied the most close config to the legacy tslint rule and disable it on jest tests/mocks files.one-var-> Disabledprefer-arrow/prefer-arrow-functions-> DisabledUseful tools:
Official @typescript-eslint migration guide
Old tslint recommended rules
It also solves #34517