Skip to content

make emotion typing global #200958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

make emotion typing global #200958

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7a3a91
make emotion typing global
eokoneyo Nov 20, 2024
6682418
fix test to match new theme expectation within Kibana
eokoneyo Nov 20, 2024
f80a58b
add comment with reference to issue for lint issue
eokoneyo Nov 28, 2024
0b48a6d
remove re-include of emotion declaration for osquery
eokoneyo Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions x-pack/plugins/osquery/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
"server/**/*",
"../../../typings/**/*",
Copy link
Contributor Author

@eokoneyo eokoneyo Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply having this includes the appropriate typing for emotion by default now

// ECS and Osquery schema files
"public/common/schemas/*/**.json",
// Emotion theme typing
"../../../typings/emotion.d.ts"
"public/common/schemas/*/**.json"
],
"kbn_references": [
"@kbn/core",
Expand Down
Loading