[Synthetics] remove full screenshots #189911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
dominiqueclarke
added
bug
dominiqueclarke
changed the title
maryam-saeidi
approved these changes
Aug 7, 2024
Member
maryam-saeidi
left a comment
maryam-saeidi
left a comment
There was a problem hiding this comment.
LGTM!
Do we need a release note that the full screenshot is not supported anymore?
dominiqueclarke
added
release_note:deprecation
and removed
release_note:skip
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
lcawl
added
the
Team:actionable-obs
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
|
Added team label for release note purposes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have not used full screenshot image data since early alpha versions of Synthetics (pre 7.14.0), and there is no reason to not use screenshot blocks instead as they make far more efficient storage performance.
Release note
Removes support for Heartbeat browser monitor screenshots for lower versions of Heartbeat. Please upgrade to Heartbeat 7.17.24 to continue using Heartbeat browser monitor screenshots.
Testing
Screenshots are just for browser monitors, and browser monitors are in Beta in 7.17.x and will never be moved to GA. I don't believe this ticket needs additional testing beyond passing integration tests.