-
Notifications
You must be signed in to change notification settings - Fork 519
[gcp_vpcflow_otel] Content pack of EDOT Cloud Forwarder for GCP - VPC Flow Logs #16439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alaudazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor suggestion.
|
Please follow the best practices: Avoid using “count” or “number” unless it leads to ambiguity Break down complex widget names with hyphen |
As for the
Intuitively I decided that it would be better as a control. What do you think about that? |
Should I remove all axis names? (The remaining are:
Thanks, I'll do that |
As i mentioned, if the multi-select of the value is possible in the input control, it would be best to have it split by the "reporter" value type so that comparison is possible - provided that it has an observability relevance.
You could consider renaming "Traffic volume over time" as "Total bytes sent" and in the y-axis you can put the y-axis label "Bytes" |
ShourieG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end
@mykola-elastic : This is our current dashboard from Elastic (data is not there) and from the comparison I did we do have most of fields are present via the logging extension. |
constanca-m
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much knowledge on content packs, but it looks good to me
|
@agithomas @ishleenk17 Updated the dashboard according to your suggestions:
Before:
After:
|
|
I also don't have much knowledge on content packs, but looks like a good start for Tech Preview, thank you! Thank you for trying to match the ECS equivalent current dashboard.
For example, I realize we are missing panels vs the existing dashboard (thank you @ishleenk17 for pointing that out, I think it's important to compare existing vs OTEL):
I think those would be super useful and eventually necessary. But, I don't think we need to put them in this PR; we can interate. Can we get these tracked somehow? I also think it would be good to take these assets a step further and eventually
Maybe we can pull in a Security UX person to say what are "must-haves" and help us with a user journey here. CC @mlunadia |
We already have security folks involved in the PR review. @mykola-elastic : Some of the Y axis has |
💚 Build Succeeded
History
|
|
Package gcp_vpcflow_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/gcp_vpcflow_otel/0.1.0/ |




Proposed commit message
See title.
Checklist
changelog.ymlfile.Screenshots
(null)value from countries bar chart (as it will drop a big portion of logs for which the country couldn't be deduced)