-
Notifications
You must be signed in to change notification settings - Fork 521
fix integrations with failing parsing hbs templates #16230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🚀 Benchmarks reportTo see the full report comment with |
| processors: | ||
| {{processors}} | ||
| {{/if}} | ||
| {{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this closing "if" be moved between line 41 and 42 (after setting all tags)?
--- packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
+++ packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
@@ -39,6 +39,7 @@ tags:
{{#each tags as |tag|}}
- {{tag}}
{{/each}}
+{{/if}}
{{#contains "forwarded" tags}}
publisher_pipeline.disable_host: true
{{/contains}}
@@ -46,4 +47,3 @@ publisher_pipeline.disable_host: true
processors:
{{processors}}
{{/if}}
-{{/if}}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should it be after checking the forwarded tag ?
--- packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
+++ packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
@@ -42,8 +42,8 @@ tags:
{{#contains "forwarded" tags}}
publisher_pipeline.disable_host: true
{{/contains}}
+{{/if}}
{{#if processors}}
processors:
{{processors}}
{{/if}}
-{{/if}}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right, i've changed into before forwarded, as this condition is based on tags but does not modify the tag list, it adds a bool variable to the policy.
I've checked this changed adding two policy test to the package 🧪
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
netskope changes LGTM ✅
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
|
@elastic/sec-linux-platform hi! could you take a look to this change? thanks! |
Proposed commit message
netskope and auditd_manager fixed on hbs syntaxChecklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
This PR fixes errors on the integrations that do not have valid handlebars format. This is a new validation rule that would be available at package-spec. Integrations affected are:
netskopeerror when using gcsnetskopeCollect logs from Netskope using Log Streaming via GCSso the data stream with the fault is usedWith this change this error does not appear.
auditd_managerdefault audit rules formatThe use of multiline string inside the helper is not compliant with handlebars. The file has been changed so the default values are a single line. The helper still formats the variable input from the user.
Related issues
Related elastic/package-spec#1030