Skip to content

Conversation

@teresaromero
Copy link
Contributor

@teresaromero teresaromero commented Dec 3, 2025

Proposed commit message

netskope and auditd_manager fixed on hbs syntax

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

This PR fixes errors on the integrations that do not have valid handlebars format. This is a new validation rule that would be available at package-spec. Integrations affected are:

netskope error when using gcs

  • install netskope
  • choose Collect logs from Netskope using Log Streaming via GCS so the data stream with the fault is used
Screenshot 2025-12-05 at 12 22 38

With this change this error does not appear.

auditd_manager default audit rules format

The use of multiline string inside the helper is not compliant with handlebars. The file has been changed so the default values are a single line. The helper still formats the variable input from the user.

Related issues

Related elastic/package-spec#1030

@teresaromero teresaromero added the bugfix Pull request that fixes a bug issue label Dec 3, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 3, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@teresaromero teresaromero marked this pull request as ready for review December 11, 2025 09:15
@teresaromero teresaromero requested review from a team as code owners December 11, 2025 09:15
processors:
{{processors}}
{{/if}}
{{/if}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this closing "if" be moved between line 41 and 42 (after setting all tags)?

--- packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
+++ packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
@@ -39,6 +39,7 @@ tags:
 {{#each tags as |tag|}}
   - {{tag}}
 {{/each}}
+{{/if}}
 {{#contains "forwarded" tags}}
 publisher_pipeline.disable_host: true
 {{/contains}}
@@ -46,4 +47,3 @@ publisher_pipeline.disable_host: true
 processors:
 {{processors}}
 {{/if}}
-{{/if}}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should it be after checking the forwarded tag ?

--- packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
+++ packages/netskope/data_stream/alerts_events_v2/agent/stream/gcs.yml.hbs
@@ -42,8 +42,8 @@ tags:
 {{#contains "forwarded" tags}}
 publisher_pipeline.disable_host: true
 {{/contains}}
+{{/if}}
 {{#if processors}}
 processors:
 {{processors}}
 {{/if}}
-{{/if}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right, i've changed into before forwarded, as this condition is based on tags but does not modify the tag list, it adds a bool variable to the policy.
I've checked this changed adding two policy test to the package 🧪

@andrewkroh andrewkroh added Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 11, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netskope changes LGTM ✅

@elasticmachine
Copy link

elasticmachine commented Dec 17, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

@teresaromero
Copy link
Contributor Author

@elastic/sec-linux-platform hi! could you take a look to this change? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:auditd_manager Auditd Manager Integration:netskope Netskope Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants