Skip to content

Conversation

@tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented Jun 4, 2025

Summary

Resolves #8737

This PR adds the existing Emotion guide and frequently asked questions to the documentation site. It's the base for further content improvements.

LMK what you think of the navbar naming - I was torn between having a primary Emotion link in the top bar and having something more generic prepared for more content to come.

Note that the latest comment from Anton is not included in this PR. It's because some of the content in there is duplicated, and I feel we need to rewrite it in a way that's more readable as a whole. I want to move sections around and reduce the number of answers hidden in the FAQ section

Added pages:

@tkajtoch tkajtoch self-assigned this Jun 4, 2025
@tkajtoch tkajtoch requested a review from a team as a code owner June 4, 2025 13:49
@tkajtoch tkajtoch added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) labels Jun 4, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion:

Let's move this to a subpage "Styling apps with Emotion".

According to our wiki:

It's possible to make a collapsible item be a document as well, though this is not recommended. Set the link field to have type: doc and id: <DOCUMENT_ID>, with the id from the document it should point to. If the id is not explicitly set in the document file's front matter, it's the relative path starting from the docs folder, without the file extension, e.g. docs/components/containers/accordion.

I think in this case we can easily put this as a "introductory" page and there's no need for the folder to be a document as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the Slack discussion let's make this a part of the Getting started section. Good catch on the document structure!

</EuiTableRow>
</EuiTable>

#### Performing math on size tokens
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

There's some spacing issue here.

Screenshot 2025-06-05 at 13 33 50

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's technically how our current theme renders code blocks in lists. Let's fix it separately since this PR is content-only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkajtoch I don't mind doing it on another issue, can we create it though? 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great idea and seeing it through, Tomasz! It looks good to me, so I'm leaving an approve 🟢

Feel free to apply whatever suggestions you think are fair.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @tkajtoch

@tkajtoch tkajtoch merged commit 44c9ac9 into elastic:main Jun 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move existing Emotion guidelines to the docs site

3 participants