-
Notifications
You must be signed in to change notification settings - Fork 862
Add Emotion FAQ to docs #8741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emotion FAQ to docs #8741
Conversation
packages/website/docs/developer-guides/emotion/migrating-from-sass.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
Let's move this to a subpage "Styling apps with Emotion".
According to our wiki:
It's possible to make a collapsible item be a document as well, though this is not recommended. Set the
linkfield to havetype: docandid: <DOCUMENT_ID>, with theidfrom the document it should point to. If theidis not explicitly set in the document file's front matter, it's the relative path starting from thedocsfolder, without the file extension, e.g.docs/components/containers/accordion.
I think in this case we can easily put this as a "introductory" page and there's no need for the folder to be a document as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the Slack discussion let's make this a part of the Getting started section. Good catch on the document structure!
| </EuiTableRow> | ||
| </EuiTable> | ||
|
|
||
| #### Performing math on size tokens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's technically how our current theme renders code blocks in lists. Let's fix it separately since this PR is content-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkajtoch I don't mind doing it on another issue, can we create it though? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/website/docs/developer-guides/emotion/migrating-from-sass.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/developer-guides/emotion/migrating-from-sass.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/developer-guides/emotion/migrating-from-sass.mdx
Outdated
Show resolved
Hide resolved
packages/website/docs/developer-guides/emotion/migrating-from-sass.mdx
Outdated
Show resolved
Hide resolved
…sass.mdx Co-authored-by: Weronika Olejniczak <[email protected]>
…sass.mdx Co-authored-by: Weronika Olejniczak <[email protected]>
…sass.mdx Co-authored-by: Weronika Olejniczak <[email protected]>
…sass.mdx Co-authored-by: Weronika Olejniczak <[email protected]>
…sass.mdx Co-authored-by: Weronika Olejniczak <[email protected]>
Co-authored-by: Weronika Olejniczak <[email protected]>
Co-authored-by: Weronika Olejniczak <[email protected]>
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great idea and seeing it through, Tomasz! It looks good to me, so I'm leaving an approve 🟢
Feel free to apply whatever suggestions you think are fair.
💚 Build SucceededHistory
cc @tkajtoch |
💚 Build Succeeded
History
cc @tkajtoch |

Summary
Resolves #8737
This PR adds the existing Emotion guide and frequently asked questions to the documentation site. It's the base for further content improvements.
LMK what you think of the navbar naming - I was torn between having a primary Emotion link in the top bar and having something more generic prepared for more content to come.
Note that the latest comment from Anton is not included in this PR. It's because some of the content in there is duplicated, and I feel we need to rewrite it in a way that's more readable as a whole. I want to move sections around and reduce the number of answers hidden in the FAQ section
Added pages: