This repository was archived by the owner on Sep 21, 2023. It is now read-only.
actions: use go-version-file: .go-version#193
Merged
v1v merged 1 commit intoelastic:mainfrom Nov 30, 2022
Merged
Conversation
v1v
requested review from
a team,
faec and
leehinman
and removed request for
a team
v1v
added
backport-v8.5.0
amannocci
approved these changes
Nov 30, 2022
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
cmacknz
approved these changes
Nov 30, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
see actions/setup-go#295 (cherry picked from commit d0393ab)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
see actions/setup-go#295 (cherry picked from commit d0393ab)
v1v
added a commit
that referenced
this pull request
Nov 30, 2022
see actions/setup-go#295 (cherry picked from commit d0393ab) Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v
added a commit
that referenced
this pull request
Nov 30, 2022
see actions/setup-go#295 (cherry picked from commit d0393ab) Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
setup-goaction with thego-version-fileinput so it reads the file.go-versionWhy is it important?
Avoid the logic to read and create env variables and use the undocumented
.go-version-fileSee actions/setup-go#295