Support stack versions in versioned plugin docs.#70
Merged
mashhurs merged 3 commits intoelastic:mainfrom Apr 14, 2022
mashhurs:support-stack-versions-in-vpr-docs
Merged
Support stack versions in versioned plugin docs.#70mashhurs merged 3 commits intoelastic:mainfrom mashhurs:support-stack-versions-in-vpr-docs
mashhurs merged 3 commits intoelastic:mainfrom
mashhurs:support-stack-versions-in-vpr-docs
Conversation
36 tasks
andsel
reviewed
Apr 1, 2022
Contributor
andsel
left a comment
andsel
left a comment
There was a problem hiding this comment.
From a logical point, it seems correct to me.
Never seen the doc tooling, so I'm not able to foresee problems.
jsvd
reviewed
Apr 12, 2022
Member
jsvd
left a comment
jsvd
left a comment
There was a problem hiding this comment.
Overall LGTM w/ few minor nitpicks on style and reducing the need for extra checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Issue: #46
When customers visit versioned plugin reference pages and go through the links to stack versions, they will be always forwarded to
currentstack version documents. This leads confusion (example reported issue) and not guiding customers properly, example case.This PR suggests to add stack version to the VPR docs when new plugin releases happen so that we can easily use that version to forward the customers to proper stack version reference pages.
Closes #46
Test
mashhurs/doc-tools. Then called inmashhurs/logstash-docsVPR workflow.