Skip to content

[9.0](backport #42565) Add latency metrics for logstash async output #42586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdner merged 3 commits into from
Feb 5, 2025
Merged

[9.0](backport #42565) Add latency metrics for logstash async output #42586

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c502f20
Add latency metrics for logstash async output (#42565)
strawgate Feb 4, 2025
1d05a03
Merge branch '9.0' into mergify/bp/9.0/pr-42565
rdner Feb 4, 2025
14e48b7
Merge branch '9.0' into mergify/bp/9.0/pr-42565
strawgate Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions libbeat/outputs/logstash/async.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ func (c *asyncClient) sendEvents(ref *msgRef, events []publisher.Event) error {
window[i] = &events[i].Content
}
ref.count.Add(1)
return client.Send(ref.callback, window)

return client.Send(ref.customizedCallback(), window)
}

func (c *asyncClient) getClient() *v2.AsyncClient {
Expand All @@ -231,7 +232,15 @@ func (c *asyncClient) getClient() *v2.AsyncClient {
return client
}

func (r *msgRef) callback(n uint32, err error) {
func (r *msgRef) customizedCallback() func(uint32, error) {
start := time.Now()

return func(n uint32, err error) {
r.callback(start, n, err)
}
}

func (r *msgRef) callback(start time.Time, n uint32, err error) {
r.client.observer.AckedEvents(int(n))
r.slice = r.slice[n:]
r.deadlockListener.ack(int(n))
Expand All @@ -246,6 +255,11 @@ func (r *msgRef) callback(n uint32, err error) {
r.win.tryGrowWindow(r.batchSize)
}
}

// Report the latency for the batch of events
duration := time.Since(start)
r.client.observer.ReportLatency(duration)

r.dec()
}

Expand Down
Loading