Skip to content

fix: don't throw on older versions of Node.js 6 #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
watson merged 1 commit into from
Dec 5, 2018
Merged

fix: don't throw on older versions of Node.js 6 #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/instrumentation/http-shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,12 @@ function isRequestBlacklisted (agent, req) {
// NOTE: This will also stringify and parse URL instances
// to a format which can be mixed into the options object.
function ensureUrl (v) {
if (typeof v === 'string' || v instanceof url.URL) {
return url.parse(String(v))
if (typeof v === 'string') {
return url.parse(v)
} else if (v instanceof url.Url) {
return v
} else if (url.URL && v instanceof url.URL) { // check for url.URL because it wasn't added until Node.js 6.13.0
return url.parse(v.toString())
} else {
return v
}
Expand Down